You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !
Hi!
I realized I should’ve claimed this issue first (as per the contributing guidelines), but since it wasn’t assigned to anyone and was still open, I went ahead and fixed it.
Hope that’s okay — please review when you get a chance. I can make any necessary adjustments if needed. 😊
Hi @ksen0, just a gentle follow-up on this PR.
Please let me know if there’s anything I should update or adjust to help move it forward.
Thanks, and I appreciate your time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7876
Changes:
keyCodeusage insrc/core/main.js.keyCodeis deprecated and suggests usingkeyIsDown()instead.test/manual-test-examples/events/keyCode-warning.htmlandtest/manual-test-examples/events/keyCode-warning-sketch.jsScreenshots of the change:
PR Checklist
npm run lintpasses